| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130729153523.GA22605@mtj.dyndns.org> Date: Mon, 29 Jul 2013 11:35:23 -0400 From: Tejun Heo <tj@...nel.org> To: Shaohua Li <shli@...nel.org> Cc: linux-kernel@...r.kernel.org Subject: Re: [patch]workqueue: copy attr with all fields. Hello, On Mon, Jul 29, 2013 at 08:52:59PM +0800, Shaohua Li wrote: > Ah, ok, I thought it's straightforward... It's a bug fix. It never is, seriously. If it's something trivial / straighforward, please say so in the patch description because not doing so forces other people to guess the intention behind the change which sucks and this isn't even that trivial. > echo '0' > /sys/bus/workqueue/devices/xxx/numa > cat /sys/bus/workqueue/devices/xxx/numa > I got 1. It should be 0, the reason is copy_workqueue_attrs() called in > apply_workqueue_attrs() doesn't copy no_numa field. Note that copy_workqueue_attrs() is also used while creating worker pools and this change would mean that there will be worker pools with no_numa attribute assigned basically randomly depending on which wq created the pool for the first time which should be fine AFAICS but isn't very nice. Given that there's only single place where a pool's attrs is set, maybe it'd be best to clear no_numa right after copy and explain what's going on there? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists