linux-kernel - Re: [PATCH] staging: android: logger..c fixed a brace coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130729182049.GA18299@kroah.com>
Date:	Mon, 29 Jul 2013 11:20:49 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	abbasjasim <abbasjasim.aj@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: logger..c fixed a brace coding style
 issue

On Sun, Jul 28, 2013 at 04:47:51PM +0300, abbasjasim wrote:
> fixed a coding style issue.
> 
> Signed-off-by: Abbas J. Mohammed <abbasjasim.AJ@...il.com>
> ---
>  drivers/staging/android/logger.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
> index ffc2d04..3d5180a 100644
> --- a/drivers/staging/android/logger.c
> +++ b/drivers/staging/android/logger.c
> @@ -81,8 +81,9 @@ static inline struct logger_log *file_get_log(struct file *file)
>  	if (file->f_mode & FMODE_READ) {
>  		struct logger_reader *reader = file->private_data;
>  		return reader->log;
> -	} else
> +	} else {
>  		return file->private_data;
> +	}

I think the existing code is just fine, no need for this patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/