linux-kernel - Re: [PATCH v3] gpio: add GPIO support for F71882FG and F71889F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jul 2013 22:26:09 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Simon Guinot <simon.guinot@...uanux.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v3] gpio: add GPIO support for F71882FG and F71889F

On Monday, July 29, 2013 05:59:08 PM Linus Walleij wrote:
> On Mon, Jul 22, 2013 at 11:50 AM, Simon Guinot
> <simon.guinot@...uanux.org> wrote:
> 
> > This patch adds support for the GPIOs found on the Fintek super-I/O
> > chips F71882FG and F71889F.
> >
> > A super-I/O is a legacy I/O controller embedded on x86 motherboards. It
> > is used to connect the low-bandwidth devices. Among others functions the
> > F71882FG/F71889F provides: a parallel port, two serial ports, a keyboard
> > controller, an hardware monitoring controller and some GPIO pins.
> >
> > Note that this super-I/Os are embedded on some Atom-based LaCie NASes.
> > The GPIOs are used to control the LEDs and the hard drive power.
> >
> > Signed-off-by: Simon Guinot <simon.guinot@...uanux.org>
> > ---
> > Changes since v2:
> > - Remove useless NULL setters for driver data.
> 
> Given the recent discussion with Rafael I want to have an
> extended discussion of this patch.
> 
> It is my current understanding that:
> 
> - It is possible to define the whereabouts of the SuperIO
>   chips using ACPI
> - It is possible for developers to influence the source
>   AML for the DSDT tables of these systems.
> - It is the proper thing to do.
> - So we should atleast support ACPI probing with the
>   port-based detection as a final fallback if all else fails.
> 
> Why can I not get something like:
> 
> #include <linux/acpi.h>
> (...)
> static const struct acpi_device_id gpio_acpi_match[] = {
>         { "FOOBAR", 0 },
>         { }
> };
> MODULE_DEVICE_TABLE(acpi, gpio_acpi_match);
> 
> static struct platform_driver gpio_driver = {
>         (...)
>         .driver         = {
>                  (...)
>                 .acpi_match_table = ACPI_PTR(gpio_acpi_match),
>         },
> };
> 
> ?
> 
> If there is something wrong in my reasoning above, please
> share it!

In addition to that, the "FOOBAR" PNP ID needs to be added to the
acpi_platform_device_ids[] table in drivers/acpi/acpi_platform.c.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/