linux-kernel - Re: [PATCH V8 04/15] perf tools: change machine__findnew

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51F6EA60.7020208@gmail.com>
Date:	Mon, 29 Jul 2013 16:19:12 -0600
From:	David Ahern <dsahern@...il.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH V8 04/15] perf tools: change machine__findnew_thread()
 to set thread pid

On 7/28/13 4:43 AM, Adrian Hunter wrote:

>>> - thread = machine__findnew_thread(machine, event->ip.pid);
>>> + thread = machine__findnew_thread(machine, event->ip.pid,
>>> event->ip.pid);
>>
>> event->ip.tid? at a minimum current functionality is retained with
>> machine__findnew_thread(machine, 0, event->ip.pid)
>
> perf tools records mmap information against the process's main thread
> for which pid == tid.  So the correct values are being passed here.

Yes. It's a case by case -- if you want syms use pid, otherwise use tid. 
It would be less confusing if the API was improved - always take pid and 
tid along with an arg that says 'want syms' or a separate function name. 
But I digress.

Looking at your patch does maintain the tid element so it should be 
fine. I ran a few tests with perf-script and the output is the same 
after the patch, so..

Acked-by: David Ahern <dsahern@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/