[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20130729155210.cc90c5790ad83d63bd30e508@linux-foundation.org>
Date: Mon, 29 Jul 2013 15:52:10 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Joe Perches <joe@...ches.com>
Cc: Dave Hansen <dave@...1.net>, Andy Whitcroft <apw@...onical.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: enforce sane perl version
On Mon, 29 Jul 2013 13:10:13 -0700 Joe Perches <joe@...ches.com> wrote:
> On Mon, 2013-07-29 at 13:06 -0700, Dave Hansen wrote:
> > From: Dave Hansen <dave.hansen@...ux.intel.com>
> >
> > I got a bug report from a couple of users who said
> > checkpatch.pl was broken for them. It was erroring out on
> > fairly random lines most commonly with messages like:
> >
> > Nested quantifiers in regex; marked by <--HERE in m/(\((?:[^\(\)]++ <-- HERE |(?-1))*\))/ at ./checkpatch.pl line 340.
> >
> > The bug reporter was running a version of perl 5.8 which was
> > end-of-lifed in 2008: http://www.cpan.org/src/. Versions of perl
> > this old are at _best_ quite untested. At worst, they are crusty
> > and known to be completely broken.
> >
> > If folks have a system _that_ old, then we should have mercy on
> > them and give them a half-decent error message rather than fail
> > with nutty error messages.
> >
> > This patch enforces that checkpatch.pl is run with perl 5.10,
> > which was end-of-lifed in 2009. The new --ignore-perl-version
> > command-line switch will let folks override this if they want.
> >
> > Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
>
> Other than Andrew Morton's (continuing?) use of perl 5.8
> I'm fine with this.
>
> Andrew? Time to update your perl version?
I run an FC6 test box just to irritate you guys.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists