linux-kernel - Re: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130730173800.1825a1452694f40370699413@canb.auug.org.au>
Date:	Tue, 30 Jul 2013 17:38:00 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH - diffstat only] include/net: Remove extern from
 function prototypes

Hi Joe,

On Tue, 30 Jul 2013 00:10:01 -0700 (PDT) David Miller <davem@...emloft.net> wrote:
>
> From: Joe Perches <joe@...ches.com>
> Date: Tue, 23 Jul 2013 10:58:11 -0700
> 
> > Function prototypes don't need to be declared
> > extern in .h files.  It's assumed by the compiler
> > and is as unnecessary as using auto is when
> > declaring automatic/local variables in a block.
> > 
> > I ran a script to remove these unnecessary extern
> > uses from function prototypes in include/net/ as
> > well as reflow the function arguments to 80 cols.
> > 
> > It's 370KB, far too large to submit at once.
> > 
> > Of course it could be broken into multiple patches
> > for the various directories/subsystems.
> 
> No objections from me.

I must admit I prefer the other way (i.e. with the explicit extern).  If
nothing else it makes it consistent with variable declarations in header
files (which need the extern) and "static inlines" ...

Making these churn changes also will almost certainly cause unnecessary
conflicts :-(

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped