linux-kernel - Re: [PATCH] drivers: power: reset: add msm restart support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130730002027.GD8868@codeaurora.org>
Date:	Mon, 29 Jul 2013 17:20:28 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Abhimanyu Kapur <abhimany@...eaurora.org>
Cc:	Anton Vorontsov <anton@...msg.org>, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: power: reset: add msm restart support

On 07/29, Abhimanyu Kapur wrote:
> diff --git a/Documentation/devicetree/bindings/power_supply/msm-poweroff.txt b/Documentation/devicetree/bindings/power_supply/msm-poweroff.txt
> new file mode 100644
> index 0000000..de08480
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power_supply/msm-poweroff.txt
> @@ -0,0 +1,17 @@
> +MSM Poweroff Driver
> +
> +A power supply hold (ps-hold) bit is set to power the msm chipsets.
> +Clearing that bit enables us to restart/poweroff. The difference

s/enables us/allows us/ perhaps?

> +between poweroff and restart is determined by unique power manager IC
> +settings.
> +
> +Required Properties:
> +-compatible: "qcom,pshold"
> +-reg: Specifies the physical address of the ps-hold register
> +
> +Example:
> +
> +	restart@...820 {
> +		compatible = "qcom,pshold";
> +		reg = <0x00800820 0x4>;
> +	};
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 349e9ae..fa6178f 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -37,3 +37,9 @@ config POWER_RESET_VEXPRESS
>  	help
>  	  Power off and reset support for the ARM Ltd. Versatile
>  	  Express boards.
> +
> +config POWER_RESET_MSM
> +	bool "Qualcomm MSM power-off driver"
> +	depends on POWER_RESET && ARCH_MSM
> +	help
> +	  Power off and restart support for Qualcomm boards.

It looks like this Kconfig file is trying to be alphabetically
ordered. Please make sure that it's maintained.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/