linux-kernel - Re: [PATCH v3 2/8] cgroup: document how cgroup IDs are assigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130730142252.GJ12016@htj.dyndns.org>
Date:	Tue, 30 Jul 2013 10:22:59 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Glauber Costa <glommer@...allels.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	Johannes Weiner <hannes@...xchg.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [PATCH v3 2/8] cgroup: document how cgroup IDs are assigned

On Tue, Jul 30, 2013 at 09:08:14AM +0800, Li Zefan wrote:
> On 2013/7/30 2:26, Tejun Heo wrote:
> > On Mon, Jul 29, 2013 at 03:08:04PM +0800, Li Zefan wrote:
> >> As cgroup id has been used in netprio cgroup and will be used in memcg,
> >> it's important to make it clear how a cgroup id is allocated.
> >>
> >> For example, in netprio cgroup, the id is used as index of anarray.
> >>
> >> Signed-off-by: Li Zefan <lizefan@...ei.com>
> >> Reviewed-by: Michal Hocko <mhocko@...e.cz>
> > 
> > We can merge this into the first patch?
> > 
> 
> The first patch just changes ida to idr, it doesn't change how IDs are
> allocated, so I prefer make this a standalone patch.

Hmmm... I'd just add "while at it, add a comment explaining ..." to
the description and fold it into the prev patch but no biggie.  Please
do as you see fit.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/