lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130730185609.GB21687@gmail.com>
Date:	Tue, 30 Jul 2013 20:56:09 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	ffainelli@...ebox.fr, bigeasy@...utronix.de,
	paul.gortmaker@...driver.com, akpm@...ux-foundation.org,
	yongjun_wei@...ndmicro.com.cn, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] x86: ce4100: remove duplicated include from
 ce4100.c


* Wei Yongjun <weiyj.lk@...il.com> wrote:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  arch/x86/platform/ce4100/ce4100.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
> index 8244f5e..d62e74d 100644
> --- a/arch/x86/platform/ce4100/ce4100.c
> +++ b/arch/x86/platform/ce4100/ce4100.c
> @@ -15,7 +15,6 @@
>  #include <linux/reboot.h>
>  #include <linux/serial_reg.h>
>  #include <linux/serial_8250.h>
> -#include <linux/reboot.h>
>  
>  #include <asm/ce4100.h>
>  #include <asm/prom.h>

Hm, while at it, this file could need more cleanups:

 - nonstandard comments
 - various checkpatch complaints that seem legit
 - col80 limits were 'solved' using ugly linebreaks

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ