linux-kernel - Re: [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options to the DTSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130730201006.GD12562@lukather>
Date:	Tue, 30 Jul 2013 22:10:06 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Emilio Lopez <emilio@...pez.com.ar>,
	linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com,
	kevin.z.m.zh@...il.com, sunny@...winnertech.com,
	shuge@...winnertech.com
Subject: Re: [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options to the DTSI

Hi Sergei,

On Tue, Jul 30, 2013 at 11:07:21PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 07/30/2013 06:59 PM, Maxime Ripard wrote:
> 
> >The UARTs on the A20 can be muxed to several pins. Add a few options to
> >the DTSI so that we can start using them in the boards' DT.
> 
> >Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> >---
> >  arch/arm/boot/dts/sun7i-a20.dtsi | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> 
> >diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> >index 704fca9..9f45e8d 100644
> >--- a/arch/arm/boot/dts/sun7i-a20.dtsi
> >+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> >@@ -70,6 +70,27 @@
> >  			#address-cells = <1>;
> >  			#size-cells = <0>;
> >  			#gpio-cells = <3>;
> >+
> >+			uart0_pins_a: uart0@0 {
> 
>    Why have address part of the node name if there's not "reg" property?

It allows to easily differentiate distinct pin groups for the same IP.

A second group of pin that can be muxed to uart0 would be defined as
uart0_pins_b: uart0@1.

I could have used any other construct, like uart0-0 and uart0-1, I just
find that it fits more in the usual DT constructs.

> And the preferred node name is "serial", not "uart", according to
> the ePAPR spec (http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf).

But only for actual serial driver right? This is a pinctrl group
declaration.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)