linux-kernel - Re: [PATCH] APEI/ERST: Fix error message formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F8DF75.1030306@linux.vnet.ibm.com>
Date:	Wed, 31 Jul 2013 15:27:09 +0530
From:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	Bjorn Helgaas <bhelgaas@...gle.com>, Joe Perches <joe@...ches.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...e.de>,
	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Kees Cook <keescook@...omium.org>,
	Tony Luck <tony.luck@...el.com>, Len Brown <lenb@...nel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"Huang, Ying" <ying.huang@...el.com>
Subject: Re: [PATCH] APEI/ERST: Fix error message formatting

On 07/29/2013 08:52 PM, Borislav Petkov wrote:
> @@ -186,8 +186,8 @@ static int erst_exec_stall(struct apei_exec_context *ctx,
>
>   	if (ctx->value > FIRMWARE_MAX_STALL) {
>   		if (!in_nmi())
> -			pr_warning(FW_WARN ERST_PFX
> -			"Too long stall time for stall instruction: %llx.\n",
> +			pr_warn(FW_WARN
> +			"Too long stall time for stall instruction: 0x%llx.\n",

A minor nit: %#llx to stay consistent with the other changes later on.

>   				   ctx->value);
>   		stall_time = FIRMWARE_MAX_STALL;
>   	} else
> @@ -206,8 +206,8 @@ static int erst_exec_stall_while_true(struct apei_exec_context *ctx,
>
>   	if (ctx->var1 > FIRMWARE_MAX_STALL) {
>   		if (!in_nmi())
> -			pr_warning(FW_WARN ERST_PFX
> -		"Too long stall time for stall while true instruction: %llx.\n",
> +			pr_warn(FW_WARN
> +		"Too long stall time for stall while true instruction: 0x%llx.\n",

Ditto.


Thanks,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/