linux-kernel - Re: [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51F8F0FA.1050200@st.com>
Date:	Wed, 31 Jul 2013 12:11:54 +0100
From:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linus.walleij@...aro.org
Subject: Re: [PATCH 1/2] pinctrl: st: Convert to use devm_ioremap_resource

On 29/07/13 05:22, Sachin Kamat wrote:
> devm_request_and_ioremap is deprecated. Use devm_ioremap_resource
> instead.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  drivers/pinctrl/pinctrl-st.c |    8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 04d4506..6246d7a 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1222,11 +1222,9 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info,
>  	if (of_address_to_resource(np, 0, &res))
>  		return -ENODEV;
>  
> -	bank->base = devm_request_and_ioremap(dev, &res);
> -	if (!bank->base) {
> -		dev_err(dev, "Can't get IO memory mapping!\n");
> -		return -ENODEV;
> -	}
> +	bank->base = devm_ioremap_resource(dev, &res);
> +	if (IS_ERR(bank->base))
> +		return PTR_ERR(bank->base);
>  
>  	bank->gpio_chip = st_gpio_template;
>  	bank->gpio_chip.base = bank_num * ST_GPIO_PINS_PER_BANK;
> 
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/