linux-kernel - Re: [PATCH 1/2] staging: zram: add Crypto API support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130731124950.GB30635@kroah.com>
Date:	Wed, 31 Jul 2013 05:49:50 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Piotr Sarna <p.sarna@...tner.samsung.com>
Cc:	devel@...verdev.osuosl.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-kernel@...r.kernel.org, ngupta@...are.org,
	b.zolnierkie@...sung.com
Subject: Re: [PATCH 1/2] staging: zram: add Crypto API support

On Wed, Jul 31, 2013 at 12:16:36PM +0200, Piotr Sarna wrote:
> Hi,
> 
> On 07/30/2013 03:53 PM, Greg KH wrote:
> > On Tue, Jul 30, 2013 at 02:30:48PM +0200, Piotr Sarna wrote:
> >> Current version of zram does not allow any substitution of a default
> >> compression algorithm. Therefore, I decided to change the existing
> >> implementation of page compression by adding Crypto API compability.
> > 
> > As I have stated before, I want this code to get merged out of the
> > drivers/staging/ area _before_ any new features get added to it.  People
> > are taking too much time adding new stuff, like this, and no one seems
> > to be working to get it merged to the proper place anymore.
> > 
> 
> OK, but we actually need those features in order to test zram
> against other, competitive solutions - and then decide whether
> and how to merge it out of /drivers/staging.

Where is another "competitive solution" in the kernel?

And you are implying that as-is, zram isn't acceptable, right?  If so, I
should just delete it now as I was originally told otherwise, that's why
I merged it :(

> > So again, I'm going to have to say no to a new feature here, sorry.
> > zcache, zram, and zsmalloc need to get cleaned up and merged out of
> > staging before anything new can be added to them.
> > 
> > Or, if no one is working on that, I guess I can just delete them,
> > right?...
> > 
> 
> Is there any official TODO list of cleaning up and merging out zram?

As it came from the "zswap" code, there doesn't seem to be one :(

The code is over 2 years old now, with no percieved movement out of
staging.  If it doesn't get fixed up in the next kernel version or so, I
will have to remove it entirely.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/