linux-kernel - Re: [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes and ftrace function hash fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130731142236.GA31073@redhat.com>
Date:	Wed, 31 Jul 2013 16:22:36 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [for-next-3.11][PATCH 0/8] ftrace/tracing: Event file fixes
	and ftrace function hash fixes

On 07/31, Steven Rostedt wrote:
>
> On Wed, 2013-07-31 at 13:47 +0200, Oleg Nesterov wrote:
> > On 07/30, Steven Rostedt wrote:
> > >
> > > Using the i_private and event_mutex
> > > to verify that the event still exists to solve the race.
> >
> > To remind, we also need the "debugfs: debugfs_remove_recursive() must
> > not rely on list_empty(d_subdirs)" patch, otherwise we still have the
> > problems with the opened files.
>
> Do these patches depend on that patch?

No,

> Should I rebase to have that
> patch first?

And no.

That patch fixes the buggy debugfs_remove_recursive() and nothing else.

The test-case from the changelog can trigger the problem with or without
the recent changes. You can't (I hope) crash the kernel this way after
these changes, but the undeleted directory is still obviously bad.

Just I think that "open/delete fixes" is not complete without this fix.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/