linux-kernel - Re: [PATCH v3] microblaze: Fix clone syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130731131030.3d03c68362382dad78136cfb@linux-foundation.org>
Date:	Wed, 31 Jul 2013 13:10:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	linux-kernel@...r.kernel.org, Michal Simek <monstr@...str.eu>,
	Al Viro <viro@...IV.linux.org.uk>, dholsgrove@...inx.com,
	Rich Felker <dalias@...ifal.cx>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	James Hogan <james.hogan@...tec.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Kees Cook <keescook@...omium.org>,
	Oleg Nesterov <oleg@...hat.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	microblaze-uclinux@...e.uq.edu.au
Subject: Re: [PATCH v3] microblaze: Fix clone syscall

On Mon, 29 Jul 2013 09:01:48 +0200 Michal Simek <michal.simek@...inx.com> wrote:

> Fix inadvertent breakage in the clone syscall ABI for Microblaze
> that was introduced in this patch:
> "microblaze: switch to generic fork/vfork/clone"
> (sha1: f3268edbe6fe0ce56e62c6d6b14640aeb04864b7)
> 
> The Microblaze syscall ABI for clone takes the parent tid address in
> the 4th argument; the third argument slot is used for the stack size.
> The incorrectly-used CLONE_BACKWARDS type assigned parent tid to the
> 3rd slot.
> 
> This commit restores the original ABI so that existing userspace libc
> code will work correctly.
> 
> All kernel versions from v3.8-rc1 were affected.

x86_64 allnoconfig generates screenfuls of

In file included from fs/signalfd.c:31:
include/linux/syscalls.h:805:5: warning: "CONFIG_CLONE_BACKWARDS3" is not defined

> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -802,9 +802,14 @@ asmlinkage long sys_vfork(void);
>  asmlinkage long sys_clone(unsigned long, unsigned long, int __user *, int,
>  	       int __user *);
>  #else
> +#if CONFIG_CLONE_BACKWARDS3

Presumably ifdef here will fix that.  Please redo, retest and resend?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/