[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130801014024.GA6941@kroah.com>
Date: Wed, 31 Jul 2013 18:40:24 -0700
From: Greg KH <gregkh@...uxfoundation.org>
To: Kishon Vijay Abraham I <kishon@...com>
Cc: kyungmin.park@...sung.com, balbi@...com, jg1.han@...sung.com,
s.nawrocki@...sung.com, kgene.kim@...sung.com,
stern@...land.harvard.edu, broonie@...nel.org,
tomasz.figa@...il.com, arnd@...db.de, grant.likely@...aro.org,
tony@...mide.com, swarren@...dia.com, devicetree@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org,
linux-usb@...r.kernel.org, linux-media@...r.kernel.org,
linux-fbdev@...r.kernel.org, akpm@...ux-foundation.org,
balajitk@...com, george.cherian@...com, nsekhar@...com,
linux@....linux.org.uk, Tomasz Figa <t.figa@...sung.com>
Subject: Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework
On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote:
> +static int phy_get_id(void)
> +{
> + int ret;
> + int id;
> +
> + ret = ida_pre_get(&phy_ida, GFP_KERNEL);
> + if (!ret)
> + return -ENOMEM;
> +
> + ret = ida_get_new(&phy_ida, &id);
> + if (ret < 0)
> + return ret;
> +
> + return id;
> +}
ida_simple_get() instead? And if you do that, you can get rid of this
function entirely.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists