linux-kernel - Re: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJxxZ0NHVRzHcFqy6V5_MzbRS9Dz8R5eLp6Oz+DF6SYLWB8r8w@mail.gmail.com>
Date:	Thu, 1 Aug 2013 15:31:34 +0800
From:	Sonic Zhang <sonic.adi@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Grant Likely <grant.likely@...aro.org>,
	Steven Miao <realmz6@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	adi-buildroot-devel@...ts.sourceforge.net,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO
 controller on bf54x and bf60x.

Hi Linus,

On Tue, Jul 30, 2013 at 12:47 AM, Linus Walleij
<linus.walleij@...aro.org> wrote:
> On Fri, Jul 26, 2013 at 6:57 AM, Sonic Zhang <sonic.adi@...il.com> wrote:
>
>> Could you please comment on this patch set? It is based on your former comments.
>
> I'll get to it. I'm pretty choked right now and actually trying to have
> some vacation at the same time.
>
> In the meantime, after glancing over and noting prolific use of the
> unlikely() macro, please read the following articles:
> http://lwn.net/Articles/70473/
> http://lwn.net/Articles/420019/
>

These articles say the directives should be rarely used. Do you
suggest to remove them from the patch?

Regards,

Sonic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/