linux-kernel - Re: [PATCH] mfd: lpc_ich: Staticize struct 'lpc_chipset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130801085252.GO13298@lee--X1>
Date:	Thu, 1 Aug 2013 09:52:52 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Samuel Ortiz' <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, 'Peter Tyser' <ptyser@...-inc.com>
Subject: Re: [PATCH] mfd: lpc_ich: Staticize struct 'lpc_chipset_info'

On Thu, 01 Aug 2013, Jingoo Han wrote:

> 'lpc_chipset_info' is used only in this file.
> 
> Fix the following sparse warning:
> 
> drivers/mfd/lpc_ich.c:216:21: warning: symbol 'lpc_chipset_info' was not declared. Should it be static?
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/mfd/lpc_ich.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index 2403332..9483bc8 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -213,7 +213,7 @@ enum lpc_chipsets {
>  	LPC_COLETO,	/* Coleto Creek */
>  };
>  
> -struct lpc_ich_info lpc_chipset_info[] = {
> +static struct lpc_ich_info lpc_chipset_info[] = {
>  	[LPC_ICH] = {
>  		.name = "ICH",
>  		.iTCO_version = 1,

Applied, thanks.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/