[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20130801090046.GB21552@infradead.org>
Date: Thu, 1 Aug 2013 02:00:46 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Al Viro <viro@...IV.linux.org.uk>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] vfs.git, part 1
On Mon, Jul 01, 2013 at 08:59:49PM +0100, Al Viro wrote:
> The major change in that pile is ->readdir() replacement with ->iterate(),
> dealing with ->f_pos races in ->readdir() instances for good. There's
> a lot more, but I'd prefer to split the pull request into several stages
> and this is the first obvious cutoff point. Please, pull from the
> usual place -
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
Again a little later, but iterate seems like a bad choice for a
directory specific operation in struct file operations, it really
should have "dir" somewhere in the method name.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists