linux-kernel - [PATCH] mm/hotplug: fix a drain pcp bug when offline pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Aug 2013 17:18:56 +0800
From:	Xishi Qiu <qiuxishi@...wei.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, <cody@...ux.vnet.ibm.com>,
	Liujiang <jiang.liu@...wei.com>,
	Minchan Kim <minchan@...nel.org>,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	<b.zolnierkie@...sung.com>
CC:	<linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] mm/hotplug: fix a drain pcp bug when offline pages

__offline_pages()
   start_isolate_page_range()
      set_migratetype_isolate()
         set_pageblock_migratetype() -> this pageblock will be marked as MIGRATE_ISOLATE
         move_freepages_block() -> pages in PageBuddy will be moved into MIGRATE_ISOLATE list
         drain_all_pages() -> drain PCP
            free_pcppages_bulk()
               mt = get_freepage_migratetype(page); -> PCP's migratetype is not MIGRATE_ISOLATE
               __free_one_page(page, zone, 0, mt); -> so PCP will not be freed into into MIGRATE_ISOLATE list

In this case, the PCP may be allocated again, because they are not in 
PageBuddy's MIGRATE_ISOLATE list. This will cause offline_pages failed.

Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
---
 mm/page_alloc.c     |   10 ++++++----
 mm/page_isolation.c |   15 ++++++++++++++-
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b100255..d873471 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -965,11 +965,13 @@ int move_freepages(struct zone *zone,
 		}
 
 		order = page_order(page);
-		list_move(&page->lru,
-			  &zone->free_area[order].free_list[migratetype]);
-		set_freepage_migratetype(page, migratetype);
+		if (get_freepage_migratetype(page) != migratetype) {
+			list_move(&page->lru,
+				&zone->free_area[order].free_list[migratetype]);
+			set_freepage_migratetype(page, migratetype);
+			pages_moved += 1 << order;
+		}
 		page += 1 << order;
-		pages_moved += 1 << order;
 	}
 
 	return pages_moved;
diff --git a/mm/page_isolation.c b/mm/page_isolation.c
index 383bdbb..ba1afc9 100644
--- a/mm/page_isolation.c
+++ b/mm/page_isolation.c
@@ -65,8 +65,21 @@ out:
 	}
 
 	spin_unlock_irqrestore(&zone->lock, flags);
-	if (!ret)
+
+	if (!ret) {
 		drain_all_pages();
+		/*
+		 * When drain_all_pages() frees cached pages into the buddy
+		 * system, it uses the stale migratetype cached in the
+		 * page->index field, so try to move free pages to ISOLATE
+		 * list again.
+		 */
+		spin_lock_irqsave(&zone->lock, flags);
+		nr_pages = move_freepages_block(zone, page, MIGRATE_ISOLATE);
+		__mod_zone_freepage_state(zone, -nr_pages, migratetype);
+		spin_unlock_irqrestore(&zone->lock, flags);
+	}
+
 	return ret;
 }
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/