linux-kernel - Re: [26/84] ARM: OMAP: RX-51: change probe order of touchscreen and panel SPI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375349525.3556.14.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 01 Aug 2013 11:32:05 +0200
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Sebastian Reichel <sre@...ian.org>
Cc:	Aaro Koskinen <aaro.koskinen@....fi>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, akpm@...ux-foundation.org,
	Felipe Balbi <balbi@...com>,
	Pali Rohár <pali.rohar@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Joni Lapilainen <joni.lapilainen@...il.com>
Subject: Re: [26/84] ARM: OMAP: RX-51: change probe order of touchscreen and
 panel SPI devices

On Thu, 2013-08-01 at 08:49 +0300, Tomi Valkeinen wrote:
> Hi,
> 
> On 31/07/13 16:23, Ben Hutchings wrote:
> > 3.2.50-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Aaro Koskinen <aaro.koskinen@....fi>
> > 
> > commit e65f131a14726e5f1b880a528271a52428e5b3a5 upstream.
> > 
> > Commit 9fdca9df (spi: omap2-mcspi: convert to module_platform_driver)
> > broke the SPI display/panel driver probe on RX-51/N900. The exact cause is
> > not fully understood, but it seems to be related to the probe order. SPI
> > communication to the panel driver (spi1.2) fails unless the touchscreen
> > (spi1.0) has been probed/initialized before. When the omap2-mcspi driver
> > was converted to a platform driver, it resulted in that the devices are
> > probed immediately after the board registers them in the order they are
> > listed in the board file.
> 
> I'm not really familiar with this issue, but:
> 
> The commit 9fdca9df was merged to v3.5. Has that also been backported to
> 3.2? If not, I don't think this patch is needed for 3.2, as the patch
> causing the problem is not in 3.2.

It has not, but Sebastian reported that 3.2 was broken in the same way
so perhaps the blame was wrongly assigned in this commit message.
Sebastian, can you confirm that it is fixed with 3.2.50-rc1?

Ben.

-- 
Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)