lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 1 Aug 2013 10:42:25 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Marek Belisko <marek.belisko@...il.com>
Cc:	perex@...ex.cz, tiwai@...e.de, grant.likely@...aro.org,
	rob.herring@...xeda.com, lgirdwood@...il.com,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	zonque@...il.com, Marek Belisko <marek.belisko@...eamunlimited.com>
Subject: Re: [PATCH v2] ASoC: Add PCM1681 codec driver.

On Thu, Aug 01, 2013 at 11:14:58AM +0200, Marek Belisko wrote:
> PCM1681 can be controlled via I2C, SPI or in bootstrap mode (no control mode). This code add
> support only for I2C mode.

Applied, thanks.  One thing:

> +	if (val != -1) {
> +		regmap_update_bits(priv->regmap, PCM1681_DEEMPH_CONTROL,
> +					PCM1681_DEEMPH_RATE_MASK, val);
> +		enable = 1;
> +	} else
> +		enable = 0;

The style is to have braces on both sides of the else if it's one one.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists