lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <51FA36AC.1090609@citrix.com>
Date:	Thu, 1 Aug 2013 12:21:32 +0200
From:	Roger Pau Monné <roger.pau@...rix.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	<xen-devel@...ts.xen.org>, <linux-kernel@...r.kernel.org>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>
Subject: Re: [Xen-devel] [PATCH RFC] p2m: use GNTTABOP_unmap_and_duplicate
 if	available

On 01/08/13 11:53, David Vrabel wrote:
> On 31/07/13 17:07, Roger Pau Monne wrote:
>> The new GNTTABOP_unmap_and_duplicate operation doesn't zero the
>> mapping passed in new_addr, allowing us to perform batch unmaps in p2m
>> code without requiring the use of a multicall.
> 
> Thanks. This looks like it should be a good performance improvement for
> userspace-based backends.  Do you have any performance measurements for
> (e.g.) qemu's disk backend?

Not yet, I might be able to get some initial performance measurements
tomorrow.

> 
>> --- a/arch/x86/xen/p2m.c
>> +++ b/arch/x86/xen/p2m.c
> [...]
>> +int m2p_remove_override_batch(struct page **pages,
>> +		struct gnttab_map_grant_ref *kmap_ops, int count)
>> +{
> 
> Is it possible to refactor this function and
> m2p_remove_override_single() to share some common helper functions?

Yes, I will split those common parts into inline functions and share
them between both implementations.

Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ