linux-kernel - Re: [PATCH] crypto: remove double execution of the same test suite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130801113747.GA30622@gondor.apana.org.au>
Date:	Thu, 1 Aug 2013 21:37:47 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Stoica Cristian-B18196 <B18196@...escale.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Geanta Neag Horia Ioan-B05471 <B05471@...escale.com>
Subject: Re: [PATCH] crypto: remove double execution of the same test suite

On Thu, Aug 01, 2013 at 08:11:25AM +0000, Stoica Cristian-B18196 wrote:
> > Which algorithm (apart from crc* which I know and will fix) uses the
> > same driver name as its algorithm name? Doing this will cause issues
> > when an alternative implementation for that algorithm gets added.
> 
> Fixing names resolves double calls only for the thread cryptomgr_test->alg_test where the call is:
>     err = alg_test(param->driver, param->alg, type, CRYPTO_ALG_TESTED);
> 
> It doesn't fix the thread tcrypt_test->alg_test where the call is:
>     ret = alg_test(alg, alg, 0, 0);

Good point.  I'll apply your patch.

Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/