linux-kernel - Re: [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery charging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51FA9056.7010104@wwwdotorg.org>
Date:	Thu, 01 Aug 2013 10:44:06 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	akpm@...ux-foundation.org, grant.likely@...aro.org,
	rob.herring@...xeda.com, rob@...dley.net,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	gg@...mlogic.co.uk, kishon@...com, swarren@...dia.com,
	pawel.moll@....com, Mark.Rutland@....com, ian.campbell@...rix.com,
	broonie@...nel.org
Subject: Re: [PATCH V2] drivers/rtc/rtc-palmas.c: support for backup battery
 charging

On 08/01/2013 08:31 AM, Laxman Dewangan wrote:
> Palmas series device like TPS65913, TPS80036 supports the backup battery
> for powering the RTC when no other energy source is available.
> 
> The backup battery is optional, connected to the VBACKUP pin, and can be
> nonrechargeable or rechargeable. The rechargeable battery can be charged
> from the system supply using the backup battery charger.
> 
> Add support for enabling charging of this backup battery.  Also add the DT
> binding document and the new properties to have this support.

> diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt

> +Palmas RTC controller bindings
> +
> +Required properties:
> +- compatible:
> +  - "ti,palmas-rtc" for palma series of the RTC controller

Nit: Here is another Palma -vs- Palmas inconsistency. What is the
correct name for the device; Palma or Palmas? Either way, the should
always have an initial capital letter in free-form text (i.e. but not in
property/node names).

Aside from that, the binding looks fine to me now, assuming it's fully
describing the RTC module's functionality. So, the binding,

Reviewed-by: Stephen Warren <swarren@...dia.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/