linux-kernel - Re: [PATCH 1/5] Intel MIC Host Driver for X100 family.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375403922.61060.73.camel@blbiskey-desk1.amr.corp.intel.com>
Date:	Thu, 01 Aug 2013 17:38:42 -0700
From:	Sudeep Dutt <sudeep.dutt@...el.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Rob Landley <rob@...dley.net>, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	linux-doc@...r.kernel.org, Nikhil Rao <nikhil.rao@...el.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>,
	Caz Yokoyama <Caz.Yokoyama@...el.com>,
	Dasaratharaman Chandramouli 
	<dasaratharaman.chandramouli@...el.com>,
	Harshavardhan R Kharche <harshavardhan.r.kharche@...el.com>,
	"Yaozu (Eddie) Dong" <eddie.dong@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Sudeep Dutt <sudeep.dutt@...el.com>
Subject: Re: [PATCH 1/5] Intel MIC Host Driver for X100 family.

On Wed, 2013-07-31 at 18:45 -0700, Greg Kroah-Hartman wrote: 
> On Wed, Jul 24, 2013 at 08:31:32PM -0700, Sudeep Dutt wrote:
> > This patch enables the following:
> > a) Initializes the Intel MIC X100 PCIe devices.
> > b) Boots and shuts down the card via sysfs entries.
> > c) Allocates and maps a device page for communication with the
> > card driver and updates the device page address via scratchpad
> > registers.
> > d) Provides sysfs entries for family, stepping, state, shutdown
> > status, kernel command line, IP address, ramdisk and log buffer
> > information.
> 
> That's a lot to do in one patch, almost 4 thousand lines.  Can't you
> break this up into some more smaller, logical, and reviewable, pieces?
> 

Sure, we have started working on breaking up patch1 into smaller pieces.
The next revision will have these changes.
Thanks,
Sudeep Dutt

> For example, I have no idea what b) is, and how to separate it from the
> things you do for a) and c).
> 
> thanks,
> 
> greg k-h



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/