linux-kernel - Re: [PATCH v2] ASoC: core: init delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130802101454.GI9858@sirena.org.uk>
Date:	Fri, 2 Aug 2013 11:14:54 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, tiwai@...e.de, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: core: init delayed_work for codec-codec links

On Fri, Aug 02, 2013 at 11:01:08AM +0100, Richard Fitzgerald wrote:

> +static void codec2codec_close_delayed_work(struct work_struct *work)
> +{
> +	/* No action required.
> +	 * C2C links only represent a hardware connection and currently
> +	 * we assume that we don't have to explicitly start or stop them
> +	 */
> +}

That's not the reason - what's happening with the stream events is that
since these links are not on the edge of the DAPM graph we don't need to
interface with the outside world.  Further since we're not dealing with
the application layer there is no need to delay the power down, the
reason that's there is to stop us powering the link down if there's just
a small gap between tracks so we don't get pops, clicks and extra gaps
if the application layer is closing the device at the end of every track
(which is quite a common pattern).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)