linux-kernel - Re: [PATCH 3/3] regulators: max8660: add DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130802101824.GL9858@sirena.org.uk>
Date:	Fri, 2 Aug 2013 11:18:24 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Daniel Mack <zonque@...il.com>
Cc:	linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH 3/3] regulators: max8660: add DT bindings

On Fri, Aug 02, 2013 at 10:19:17AM +0200, Daniel Mack wrote:

> +Required properties:
> +- compatible: must be equal to "maxim,max8660"

This...

> +#ifdef CONFIG_OF
> +static const struct of_device_id max8660_dt_ids[] = {
> +	{ .compatible = "maxim,max8660", .data = (void *) MAX8660 },
> +	{ .compatible = "maxim,max8661", .data = (void *) MAX8661 },

...and this don't match up.

>  struct max8660_subdev_data {
>  	int				id;
> -	char				*name;
> +	const char			*name;
>  	struct regulator_init_data	*platform_data;
> +	struct device_node		*of_node;
>  };

Can't you just pass the of_node around while you need it?  Not that it
makes a big difference.

Otherwise looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)