linux-kernel - Re: [PATCH 3/3] acpi: video: remove unnecessary casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Aug 2013 09:58:32 +0800
From:	Aaron Lu <aaron.lwe@...il.com>
To:	Felipe Contreras <felipe.contreras@...il.com>
CC:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>, Len Brown <lenb@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH 3/3] acpi: video: remove unnecessary casting

On 08/02/2013 07:44 AM, Felipe Contreras wrote:
> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>

Looks good to me, except that no change log feels a little weird.

Reviewed-by: Aaron Lu <aaron.lu@...el.com>

Thanks,
Aaron

> ---
>  drivers/acpi/video.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> index b07573f..11bafbe 100644
> --- a/drivers/acpi/video.c
> +++ b/drivers/acpi/video.c
> @@ -236,8 +236,7 @@ static int acpi_video_get_brightness(struct backlight_device *bd)
>  {
>  	unsigned long long cur_level;
>  	int i;
> -	struct acpi_video_device *vd =
> -		(struct acpi_video_device *)bl_get_data(bd);
> +	struct acpi_video_device *vd = bl_get_data(bd);
>  
>  	if (acpi_video_device_lcd_get_level_current(vd, &cur_level, false))
>  		return -EINVAL;
> @@ -255,8 +254,7 @@ static int acpi_video_get_brightness(struct backlight_device *bd)
>  static int acpi_video_set_brightness(struct backlight_device *bd)
>  {
>  	int request_level = bd->props.brightness + 2;
> -	struct acpi_video_device *vd =
> -		(struct acpi_video_device *)bl_get_data(bd);
> +	struct acpi_video_device *vd = bl_get_data(bd);
>  
>  	return acpi_video_device_lcd_set_level(vd,
>  				vd->brightness->levels[request_level]);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/