linux-kernel - Re: [PATCH v3 6/6] mfd: da9063: add 32 kHz output clock to clock tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375444203.4098.11.camel@pizza.hi.pengutronix.de>
Date:	Fri, 02 Aug 2013 13:50:03 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Krystian Garbaciak <krystian.garbaciak@...semi.com>
Subject: Re: [PATCH v3 6/6] mfd: da9063: add 32 kHz output clock to clock
 tree

Am Montag, den 29.07.2013, 19:15 +0100 schrieb Mark Brown:
> On Mon, Jul 29, 2013 at 07:00:47PM +0200, Philipp Zabel wrote:
> 
> > +	clk = devm_clk_register(da9063->dev, &out_32k->clk_hw);
> > +	if (IS_ERR(clk))
> > +		return PTR_ERR(clk);
> > +
> 
> This introduces a dependency on COMMON_CLK.  It might be best to make
> this a function device in drivers/clk, and for something like this we
> really ought to be able to create regmap helpers though that can be done
> later on.

If we just add regmap variants of the current basic clocks (think
clk_gate_regmap etc.) there wouldn't be much code left for this function
device. I'll drop the clock part for now and reintroduce it after we
have some helpers.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/