linux-kernel - Re: [PATCH] tracing: a few fields of struct trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375468355.22073.9.camel@gandalf.local.home>
Date:	Fri, 02 Aug 2013 14:32:35 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	David Sharp <dhsharp@...gle.com>
Cc:	Andrew Vagin <avagin@...nvz.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Hiraku Toyooka <hiraku.toyooka.gu@...achi.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Subject: Re: [PATCH] tracing: a few fields of struct trace_iterator are
 zeroed by mistake

On Fri, 2013-08-02 at 11:15 -0700, David Sharp wrote:

> Wow. That is a terrible hack. Thanks for noticing it.

Why thank you :-)

It's a hack from doing things that way else where and long ago.

> 
> If I may suggest a way better idea: put these zeroed-in-pipe_read
> members in an embedded anonymous structure, and zero the structure in
> pipe_read.

Sure, sounds like a fix for 3.12.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/