linux-kernel - Re: [Patch net-next v2 1/8] net: introduce generic union inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130802.145041.845804796107623114.davem@davemloft.net>
Date:	Fri, 02 Aug 2013 14:50:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, dborkman@...hat.com, joe@...ches.com,
	linux-kernel@...r.kernel.org
Subject: Re: [Patch net-next v2 1/8] net: introduce generic union inet_addr

From: Cong Wang <amwang@...hat.com>
Date: Fri,  2 Aug 2013 15:14:27 +0800

> From: Cong Wang <amwang@...hat.com>
> 
> Introduce a generic IP address type, union inet_addr, so that
> subsystems don't have to use their own definitions. Because
> netpoll already defines union inet_addr, just move it to global.
> Some of the helper functions will be used by VXLAN IPv6 code too.
> 
> This patch also reuses the "%pIS" specifier, to make it accept
> union inet_addr instead of struct sockaddr.
> 
> Cc: Daniel Borkmann <dborkman@...hat.com>
> Cc: Joe Perches <joe@...ches.com>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Cong Wang <amwang@...hat.com>

Changing %pIS to %pIA is pure churn, and of zero value that I can see.

Every time I review this patch set I discover some new thing that I'm
very disappointed with.

You're going to have to stop being so ambitious, and start very small.

Maybe one tiny patch at a time if needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/