linux-kernel - Re: [Patch net-next v2 8/8] selinux: use generic union inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130802.145146.215059840395396296.davem@davemloft.net>
Date:	Fri, 02 Aug 2013 14:51:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pmoore@...hat.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org,
	james.l.morris@...cle.com, sds@...ho.nsa.gov,
	eparis@...isplace.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: [Patch net-next v2 8/8] selinux: use generic union inet_addr

From: Paul Moore <pmoore@...hat.com>
Date: Fri, 02 Aug 2013 10:34:07 -0400

> On Friday, August 02, 2013 03:14:34 PM Cong Wang wrote:
>> From: Cong Wang <amwang@...hat.com>
>> 
>> selinux has some similar definition like union inet_addr,
>> it can re-use the generic union inet_addr too.
>> 
>> Cc: James Morris <james.l.morris@...cle.com>
>> Cc: Stephen Smalley <sds@...ho.nsa.gov>
>> Cc: Eric Paris <eparis@...isplace.org>
>> Cc: Paul Moore <pmoore@...hat.com>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-security-module@...r.kernel.org
>> Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> Perhaps I'm confusing this with another patch but I though DaveM said he 
> wasn't going to merge these patches?

I didn't like how he added completely unused bloat to various
datastructures because he unconditionally put a port field into
there.

He removed that problem this time, but there are still a lot of
things I don't like about this patch series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/