linux-kernel - Re: [PATCH] driver-core: only call kfree() if memory was allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130802220445.GA22019@kroah.com>
Date:	Sat, 3 Aug 2013 06:04:45 +0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Andreas Platschek <andi.platschek@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver-core: only call kfree() if memory was allocated

On Fri, Aug 02, 2013 at 11:43:50PM +0200, Andreas Platschek wrote:
> There are several cases where we could bail out of show_uevent()
> before kzalloc() is even called. In those cases we don't want to
> call kfree().

Why not?  It's totally safe to do that.

> In addition the error handling of kzalloc() is now using the
> single point of exit as well.

We had the single point of exit to start with, there's no change made
there.

Sorry, but I'm not going to take this patch, it's not needed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/