linux-kernel - Re: [PATCH 2/3] acpi: video: trivial style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3692149.CN6y0aXjQ7@vostro.rjw.lan>
Date:	Sat, 03 Aug 2013 02:01:57 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	Aaron Lu <aaron.lwe@...il.com>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, Len Brown <lenb@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH 2/3] acpi: video: trivial style cleanups

On Friday, August 02, 2013 12:56:09 PM Felipe Contreras wrote:
> On Fri, Aug 2, 2013 at 9:09 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> > On Thursday, August 01, 2013 11:18:34 PM Felipe Contreras wrote:
> >> On Thu, Aug 1, 2013 at 8:55 PM, Aaron Lu <aaron.lwe@...il.com> wrote:
> >> > On 08/02/2013 07:44 AM, Felipe Contreras wrote:
> >> >> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> >> >
> >> > Change log please.
> >>
> >> You mean a commit message?
> >
> > No.  He meant the part that goes between the subject and the signoff.
> > This is called a change log (or changelog).
> 
> Not in Git lingo.
> 
> % man git commit
> 
> "Though not required, it’s a good idea to begin the commit message
> with a single short (less than 50 character) line summarizing the
> change, followed by a blank line and then a more thorough
> description."

Please go and read this: https://lwn.net/Articles/560392/

Now, you may still argue that your patches fall into the "add missing include
of foo.h" category, but it does several different things:
- fixes some whitespace,
- fixes a couple of static variable initializations,
- removes some braces,
- changes the placement of some lables (some of them unnecessarily).

It would be simply *nice* to write what it does in the changelog so that
people reading the git log don't have to look deeper to see what changes the
author meant as "trivial style cleanups".

That's just a matter of making it easier to work with you for other people,
but maybe you just want to be difficult to work with in the first place?

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/