lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130803165155.GC32568@redhat.com>
Date:	Sat, 3 Aug 2013 18:51:55 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Zach Levis <zml@...ux.vnet.ibm.com>
Cc:	akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	dan.carpenter@...cle.com, Zach Levis <zach@...hsthings.com>
Subject: Re: [PATCH v3 3/3] fs/binfmts: Whitespace fixes with
	scripts/cleanfile

On 08/02, Zach Levis wrote:
>
> Obligatory first-patchset whitespace commit

Looks good, perhaps you send it as 1/3 or even separately, so you
won't need to redo it if you need to update 1-2.

> @@ -63,11 +63,11 @@ static int load_em86(struct linux_binprm *bprm)
>  	 */
>  	remove_arg_zero(bprm);
>  	retval = copy_strings_kernel(1, &bprm->filename, bprm);
> -	if (retval < 0) return retval; 
> +	if (retval < 0) return retval;

And perhaps you can also fix the coding style when your patch touches
such a code.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ