linux-kernel - regulator: s2mps11: Question about the code updating ramp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1375521188.3891.3.camel@phoenix>
Date:	Sat, 03 Aug 2013 17:13:08 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Yadwinder Singh Brar <yadi.brar@...sung.com>
Cc:	Mark Brown <broonie@...nel.org>,
	Sangbeom Kim <sbkim73@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: regulator: s2mps11: Question about the code updating ramp_delay
 setting

Hi Yadwinder,
The code updating ramp_delay setting looks wrong to me.

Current code:
        return regmap_update_bits(rdev->regmap, ramp_reg,
                                  ramp_val << ramp_shift, 1 << ramp_shift);
I'd expect something like below:
        return regmap_update_bits(rdev->regmap, ramp_reg,
                                  ramp_mask << ramp_shift,
                                  ramp_val << ramp_shift);
I don't have the datasheet so I don't know the correct ramp_mask setting
here. Can you check if this needs fix?

Thanks,
Axel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/