linux-kernel - Re: Linux 3.2.50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1375524085.32254.26.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 03 Aug 2013 12:01:25 +0200
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Teck Choon Giam <giamteckchoon@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, Jiri Slaby <jslaby@...e.cz>,
	stable@...r.kernel.org, lwn@....net
Subject: Re: Linux 3.2.50

On Sat, 2013-08-03 at 09:09 +0800, Teck Choon Giam wrote:
[...]
> I am getting the following error while trying to compile for 32bit in
> Scientific Linux 6.4:
> 
> drivers/net/ifb.c: In function 'ifb_init_module':
> drivers/net/ifb.c:298: error: implicit declaration of function 'cond_resched'
> make[2]: *** [drivers/net/ifb.o] Error 1
> 
> Missing include of linux/sched.h in drivers/net/ifb.c file?
> 
> I tried the following patch and it does compile successfully:
> 
> --- a/drivers/net/ifb.c    2013-08-03 04:15:12.000000000 +0800
> +++ b/drivers/net/ifb.c 2013-08-03 08:43:29.040492584 +0800
> @@ -34,6 +34,7 @@
>  #include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/moduleparam.h>
> +#include <linux/sched.h>
>  #include <net/pkt_sched.h>
>  #include <net/net_namespace.h>
> 
> 
> FYI and comment please.

Yes I think that's the right change.  Linux 3.0.88-rc1 had the same
problem and I should have remembered this was needed.

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)