linux-kernel - Re: [PATCH 1/3] acpi: video: trivial costmetic cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1714177.6pDg1Dt5hn@vostro.rjw.lan>
Date:	Sat, 03 Aug 2013 13:38:47 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Felipe Contreras <felipe.contreras@...il.com>
Cc:	Aaron Lu <aaron.lwe@...il.com>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, Len Brown <lenb@...nel.org>,
	Zhang Rui <rui.zhang@...el.com>,
	Jiri Kosina <trivial@...nel.org>
Subject: Re: [PATCH 1/3] acpi: video: trivial costmetic cleanups

On Friday, August 02, 2013 08:34:29 PM Felipe Contreras wrote:
> On Fri, Aug 2, 2013 at 7:07 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> > On Friday, August 02, 2013 12:52:18 PM Felipe Contreras wrote:
> >> On Fri, Aug 2, 2013 at 9:05 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> >> > On Thursday, August 01, 2013 11:15:38 PM Felipe Contreras wrote:
> >> >> On Thu, Aug 1, 2013 at 8:50 PM, Aaron Lu <aaron.lwe@...il.com> wrote:
> >> >> > On 08/02/2013 07:43 AM, Felipe Contreras wrote:
> >> >> >> Signed-off-by: Felipe Contreras <felipe.contreras@...il.com>
> >> >> >
> >> >> > Please add change log explaining what you have changed.
> >> >> > It seems that the patch modify comment style only, some add a space and
> >> >> > some change spaces to tab, is it the case?
> >> >>
> >> >> The commit message already explains what the change is; trivial
> >> >> cosmetic cleanups. Cosmetic means it's completely superficial.
> >> >
> >> > And I have a rule not to apply patches without changelogs.  So either I'll
> >> > need to write it for you, or can you add one pretty please?
> >>
> >> The commit message is right there. Maybe Jiri can apply it then, if
> >> not, then stay happy with your untidy code.
> >
> > First of all, I didn't say I wouldn't apply the patch, did I?
> >
> > Second, I asked you *nicely* to add a changelog so that I don't need to write
> > it for you.
> >
> > I don't know what made it difficult to understand.
> >
> > Anyway, I ask everyone to write changelogs and nobody has had any problems with
> > that so far.  I don't see why I should avoid asking you to follow the rules
> > that everybody else is asked to follow.  If those rules are too difficult for
> > you to follow, I'm sorry.
> 
> The patch has a commit message that describes exactly what it does.

No, it doesn't describe it exactly.  You're contradicting facts.

> Unless there is valid feedback I will not send another version.
> 
> To me, a valid criticism to the commit message would be: "I read X,
> but I thought it would do Y". For example; "I didn't expect the patch
> to do white-space cleanups", but I think that's exactly what people
> expect when they read "trivial costmetic cleanups'.

If what you're saying was correct, then it would be sufficient to use a
"this patch fixes a bug" commit message for every bug fix, but quite evidently
that is not the case.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/