linux-kernel - Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51FE768D.1030506@hetnet.nl>
Date:	Sun, 04 Aug 2013 17:43:09 +0200
From:	Henk de Groot <henk.de.groot@...net.nl>
To:	Evan Ng <evan.sin.ng@...il.com>
CC:	pe1dnn@...at.org, gregkh@...uxfoundation.org,
	johanmeiring@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white
 space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl
 tool

Hello Evan,

When reformatting the array containing  the firmware data it may be easier 
to use 8 bytes per row. It is currently it is 16 bytes per row 
(overrunning the 80 characters/line) and this just means cutting each row 
exactly in half. In your first proposal it was completely reformatted to 
an odd 11 bytes per row which makes comparison with the original during 
review much harder and it is also easier to make mistakes.

Kind regards,

Henk.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/