linux-kernel - Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130804194053.GV9858@sirena.org.uk>
Date:	Sun, 4 Aug 2013 20:40:53 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jean-Francois Moine <moinejf@...e.fr>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Rob Herring <rob.herring@...xeda.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to
 mvebu-pcm-audio and DT doc

On Sat, Aug 03, 2013 at 06:26:36PM +0200, Jean-Francois Moine wrote:
> Russell King - ARM Linux <linux@....linux.org.uk> wrote:

> > >  static struct of_device_id kirkwood_i2s_of_match[] = {
> > > -	{ .compatible = "marvell,kirkwood-i2s" },
> > > +	{ .compatible = "marvell,mvebu-pcm-audio" },  

> > You've only just introduced "marvell,kirkwood-i2s" in the previous patch.
> > Why introduce something and then immediately change its name?  This makes
> > no sense what so ever.

> 2 patches for 2 different purposes. The first one just adds the DT
> support. It is enough for DT based kernels. But some people wanted the
> device name to be changed to 'mvebu'. So, the second patch.

There is no need for the DT name to be connected to the Linux internal
platform device name, just use the final name to start with.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)