linux-kernel - Re: [PATCH 1/1] EXT4: LazyInit Mount Bug Fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130804004904.GB19781@thunk.org>
Date:	Sat, 3 Aug 2013 20:49:04 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Nitin Singla <nitin.akshainie@...il.com>
Cc:	adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org, Manish Sharma <manishrma@...il.com>,
	kapil upadhayay <Kapil.48@...il.com>
Subject: Re: [PATCH 1/1] EXT4: LazyInit Mount Bug Fix

On Mon, Jul 15, 2013 at 12:14:18PM +0530, Nitin Singla wrote:
> -    sbi->s_itb_per_group = sbi->s_inodes_per_group /
> -                    sbi->s_inodes_per_block;
> +    sbi->s_itb_per_group = DIV_ROUND_UP(sbi->s_inodes_per_group,
> +                    sbi->s_inodes_per_block);

This would only matter if s_inodes_per_group is not a multiple of
s_inodes_per_block.  Which is never supposed to happen; mke2fs doesn't
create file systems like this.

Ancient Android build systems, before the bug was fixed, did do this
in the past, but that was a long time ago.  Where did this file system
come from?

I could apply this patch, but you should be warned that there may be
other bugs hiding here for file systems like this, both in the kernel
and in e2fsprogs.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/