linux-kernel - Re: [PATCH trivial] include/linux/coda.h: remove useless '#else'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1375665700.3133.19.camel@joe-AO722>
Date:	Sun, 04 Aug 2013 18:21:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Chen Gang F T <chen.gang.flying.transformer@...il.com>,
	'Jiri Kosina' <trivial@...nel.org>, jaharkes@...cmu.edu,
	coda@...cmu.edu, codalist@...a.cs.cmu.edu,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH trivial] include/linux/coda.h: remove useless '#else'

On Mon, 2013-08-05 at 08:24 +0800, Chen Gang wrote:
> On 07/31/2013 11:16 AM, Chen Gang F T wrote:
> > On 07/31/2013 09:53 AM, Chen Gang wrote:
> >> On 07/31/2013 09:44 AM, Chen Gang wrote:
> >>> On 07/30/2013 08:29 PM, Joe Perches wrote:
> >>>> On Tue, 2013-07-30 at 15:30 +0800, Chen Gang wrote:
> >>>>> '#else' is useless, need remove.
> >>>>>
> >>>>> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> >>>>> ---
> >>>>>  include/linux/coda.h |    1 -
> >>>>>  1 files changed, 0 insertions(+), 1 deletions(-)
> >>>>>
> >>>>> diff --git a/include/linux/coda.h b/include/linux/coda.h
> >>>>> index cff544f..d30209b 100644
> >>>>> --- a/include/linux/cod
> >>>>> +++ b/include/linux/coda.h
> >>>>> @@ -60,7 +60,6 @@ Mellon the rights to redistribute these changes without encumbrance.
> >>>>>  
> >>>>>  #if defined(__linux__)
> >>>>>  typedef unsigned long long u_quad_t;
> >>>>> -#else
> >>>>>  #endif
> >>>>>  #include <uapi/linux/coda.h>
> >>>>>  #endif 
> >>>>
> >>>> Why have the #if at all?
> >>>>
> 
> Hmm... if any members have some questions about the fix, commonly it
> means the related fix need additional improvement.
> 
> Is it better to use BUILD_BUG() for the fix ?

Probably not.  __linux__ is predefined by gcc.

Using an #ifdef __linux__ might make some sense in
in include/uapi, but not in include/linux.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/