linux-kernel - Re: [PATCH 3/4] dts: dra7-evm: add USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51FF5A69.7040604@ti.com>
Date:	Mon, 5 Aug 2013 10:55:21 +0300
From:	Roger Quadros <rogerq@...com>
To:	George Cherian <george.cherian@...com>
CC:	<tony@...mide.com>, <rnayak@...com>, <benoit.cousson@...aro.org>,
	<balbi@...com>, <kishon@...com>, <dmurphy@...com>,
	<t-kristo@...com>, <linux-omap@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] dts: dra7-evm: add USB support

On 08/02/2013 06:04 PM, George Cherian wrote:
> On 8/1/2013 8:28 PM, Roger Quadros wrote:
>> Add USB drv_vbus pinctrl information and USB mode
>> for the USB controller.
>>
>> Signed-off-by: Roger Quadros <rogerq@...com>
>> ---
>>   arch/arm/boot/dts/dra7-evm.dts |   22 ++++++++++++++++++++++
>>   1 files changed, 22 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index cb0703c..acd3c09 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -18,3 +18,25 @@
>>           reg = <0x80000000 0x60000000>; /* 1536 MB */
>>       };
>>   };
>> +
>> +&dra7_pmx_core {
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <
>> +        &usb_pins
>> +    >;
>> +
>> +    usb_pins: pinmux_usb_pins {
>> +                pinctrl-single,pins = <
>> +            0x280    0xc0000    /* usb1_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */
>> +            0x284    0xc0000 /* usb2_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */
>> +                >;
>> +        };
>> +};
>> +
>> +&dwc3_1 {
>> +    dr_mode = "otg";
> 
> otg???

What's wrong there? 
please see
Documentation/devicetree/bindings/usb/generic.txt

we want it to operate in dual role mode and hence "otg"

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/