linux-kernel - Re: [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r4e8gl5r.fsf@linaro.org>
Date:	Mon, 05 Aug 2013 09:25:04 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	nm@...com, anton@...msg.org, dwmw2@...radead.org,
	andrii.tseglytskyi@...com, jean.pihet@...oldbits.com,
	tony@...mide.com, yongjun_wei@...ndmicro.com.cn,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH RESEND] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe()

Wei Yongjun <weiyj.lk@...il.com> writes:

> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> Acked-by: Nishanth Menon <nm@...com>
> ---
> cc to linux-pm with Nishanth Menon's ACK

Thanks, queued for v3.12.

Kevin

> ---
>  drivers/power/avs/smartreflex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..c26acfc 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev)
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	sr_info->base = devm_ioremap_resource(&pdev->dev, mem);
> -	if (IS_ERR(sr_info->base)) {
> -		dev_err(&pdev->dev, "%s: ioremap fail\n", __func__);
> +	if (IS_ERR(sr_info->base))
>  		return PTR_ERR(sr_info->base);
> -	}
>  
>  	irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/