linux-kernel - Re: Linux 3.11-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130805185712.GA12225@redhat.com>
Date:	Mon, 5 Aug 2013 20:57:12 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Felipe Contreras <felipe.contreras@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 3.11-rc4

On 08/05, Linus Torvalds wrote:
>
> On Mon, Aug 5, 2013 at 11:46 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > Heh. I pulled wine-git.
> >
> > set_thread_context() does a lot of PTRACE_POKEUSER requests and then
> > it calls resume_after_ptrace() which simply does PTRACE_DETACH.
> >
> > I'll recheck tomorrow, but it really looks as if it _wants_ to leak
> > the debug registers after detach. And more, it does PTRACE_ATTACH
> > only to set these regs.
> >
> > And this is exactly what fab840f tries to prevent.
>
> Ok, so I guess it's effectively the ABI, and we should just make the
> rule be that "if you don't want stale breakpoints, then remove the
> breakpoints when you detach".

I'm afraid yes.

> And thus reverting it the right thing to do. Agreed?

Yes, yes, sure. I'll write the changelog and send git-revert tomorrow,
unless you do it yourself.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/