linux-kernel - Re: [PATCH v2 2/3] sched: factor out code to should_we

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51FF2884.4000802@linux.vnet.ibm.com>
Date:	Mon, 05 Aug 2013 09:52:28 +0530
From:	Preeti U Murthy <preeti@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	김준수 <iamjoonsoo.kim@....com>,
	"'Ingo Molnar'" <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	"'Mike Galbraith'" <efault@....de>,
	"'Paul Turner'" <pjt@...gle.com>,
	"'Alex Shi'" <alex.shi@...el.com>,
	"'Vincent Guittot'" <vincent.guittot@...aro.org>,
	"'Morten Rasmussen'" <morten.rasmussen@....com>,
	"'Namhyung Kim'" <namhyung@...nel.org>,
	"'Joonsoo Kim'" <js1304@...il.com>
Subject: Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()

On 08/02/2013 04:02 PM, Peter Zijlstra wrote:
> On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote:
>>>> You need to iterate over all the groups of the sched domain env->sd and
>>>> not just the first group of env->sd like you are doing above. This is to
>>>
>>> I don't think so.
>>> IIRC, env->sd->groups always means local group,
>>> so we don't need to find our group by iterating over all the groups.
>>
>> Take a look at update_sd_lb_stats(). That should clarify this. There is
>> an exclusive
>> local_group check there.
>>
>> sd->groups points to the first group in the list of groups under this sd.
> 
> Take a look at: 88b8dac0a
> 
Ah ok! Thanks for this pointer.

Apologies for having overlooked the fact that the sd->groups always
points to the group to which the balance_cpu belongs. And subsequent
dst_cpus for retries of load balancing also belong to the same group as
the balance_cpu.

This patch thus looks fine to me.

Regards
Preeti U Murthy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/