linux-kernel - Re: [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130805054335.GC7999@moon>
Date:	Mon, 5 Aug 2013 09:43:35 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Minchan Kim <minchan@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, luto@...capital.net,
	xemul@...allels.com, akpm@...ux-foundation.org, mpm@...enic.com,
	xiaoguangrong@...ux.vnet.ibm.com, mtosatti@...hat.com,
	kosaki.motohiro@...il.com, sfr@...b.auug.org.au,
	peterz@...radead.org, aneesh.kumar@...ux.vnet.ibm.com
Subject: Re: [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages

On Mon, Aug 05, 2013 at 10:58:35AM +0800, Wanpeng Li wrote:
> >
> >pte_to_swp_entry is passed orig_pte by vaule, not a pointer
> >so although pte_to_swp_entry clear out _PTE_SWP_SOFT_DIRTY, it does it in local-copy.
> >So orig_pte is never changed.
> 
> Ouch! Thanks for pointing out. ;-)
> 
> Reviewed-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>

Yeah, it's a bit tricky. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/