linux-kernel - RE: [char-misc 3.11 V2] mei: me: fix hardware reset flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B1AE7E13C@HASMSX106.ger.corp.intel.com>
Date:	Mon, 5 Aug 2013 05:55:18 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Shuah Khan <shuah.kh@...sung.com>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Subject: RE: [char-misc 3.11 V2] mei: me: fix hardware reset flow



> 
> On Tue, Jul 30, 2013 at 02:28:55PM +0000, Winkler, Tomas wrote:
> >
> > > Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow
> > >
> > > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote:
> > > > Both H_IS and H_IE needs to be set to receive H_RDY interrupt
> > > >
> > > > 1. Assert H_IS to clear the interrupts during hw reset and use
> > > > mei_me_reg_write instead of mei_hcsr_set as the later strips down
> > > > the H_IS
> > > >
> > > > 2. fix interrupt disablement embarrassing typo
> > > >   hcsr |= ~H_IE -> hcsr &= ~H_IE;
> > > > this will remove the unwanted interrupt on power down
> > > >
> > > > 3. remove useless debug print outs
> > > >
> > > > Cc: Shuah Khan <shuah.kh@...sung.com>
> > > > Cc: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> > > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > > > ---
> > > >
> > > > V2: Fixed typo in Shuah email
> > > >
> > > > Hope this finally resolve the ME reset issue for all
> > >
> > > Can I get a "Tested-by:" from someone to ensure that it really does
> > > solve the problem?
> >
> > Yes,  please wait for ack/test results. It works for me but
> > unfortunately I cannot go over all  9 gens of  PCH and all their
> > proliferations  where ME resides.
> > I'm putting some effort to have better legacy HW testing coverage but I'm
> not there yet.
> 
> So what happened here with this patch, does it solve the reported
> problems?

Yes,  it does but apparently there is another resume issue not related to this fix.

Thanks
Tomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/