linux-kernel - Re: [PATCH v2 3/3] dma: Add Freescale eDMA engine driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130806042514.GR29095@intel.com>
Date:	Tue, 6 Aug 2013 09:55:14 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Lu Jingchang-B35083 <B35083@...escale.com>
Cc:	"djbw@...com" <djbw@...com>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Wang Huan-B18965 <B18965@...escale.com>,
	Li Xiaochun-B41219 <B41219@...escale.com>
Subject: Re: [PATCH v2 3/3] dma: Add Freescale eDMA engine driver support

On Tue, Aug 06, 2013 at 01:24:31AM +0000, Lu Jingchang-B35083 wrote:
> > -----Original Message-----
> > From: Vinod Koul [mailto:vinod.koul@...el.com]
> > Sent: Tuesday, August 06, 2013 12:35 AM
> > To: Lu Jingchang-B35083
> > Cc: djbw@...com; shawn.guo@...aro.org; linux-kernel@...r.kernel.org;
> > linux-arm-kernel@...ts.infradead.org; Wang Huan-B18965; Li Xiaochun-
> > B41219
> > Subject: Re: [PATCH v2 3/3] dma: Add Freescale eDMA engine driver support
> > > +
> > > +static void fsl_edma_free_desc(struct virt_dma_desc *vdesc) {
> > > +	struct fsl_edma_desc *fsl_desc;
> > > +	int i;
> > > +
> > > +	fsl_desc = to_fsl_edma_desc(vdesc);
> > > +	for (i = 0; i < fsl_desc->n_tcds; i++)
> > > +			dma_pool_free(fsl_desc->echan->tcd_pool,
> > > +					fsl_desc->tcd[i].vtcd,
> > > +					fsl_desc->tcd[i].ptcd);
> > > +	kfree(fsl_desc);
> > should this be called with lock held or not?
> [Lu Jingchang-B35083] 
> The desc list to be freed is got with lock held, and the free for each desc is independent, and the lock is not needed. Thanks.
Would be apt to add this comment in the code, so that people know this function
needs to be always called with lock held!

Pls add this stuff in next rev of the patch

~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/